Debug Type Check #1046
Merged
Debug Type Check #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the npm debug command to type check before executing the run entry. If the check fails the debug will not continue.
These are possible fixes for the two type errors that are currently holding back type checking this branch. I say possible because it's not tested in game and I've only solved the issues with the current types and have no idea if the types are actually correct. Needs a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the debug command to type check before executing the run entry. If the check fails the debug will not continue.
This unfortunately breaks the TSX
watchfunction and the debugger now has to be manually restarted when code is changed. I've been unable to find a solution to this.While not ideal, an alternative is to only type-check on build and leave debug using TSX directly, like we were. Let me know if you'd rather go that way and get your
watchback.Also includes possible fixes (bbf56f7) for the two type errors that are currently holding back debug builds.
I say possible because
They need to be reviewed.